Repository navigation
Xtensa: add ESP32-S3 QR inline asm support - #288
Open
Dominaezzz wants to merge 1 commit into
Open
Dominaezzz wants to merge 1 commit into
Dominaezzz wants to merge 1 commit into
Conversation
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #265.
This PR was generated with the help of Codex.
This change adds the
qreginline assembly register class for ESP32-S3, includingq0–q7and 128-bit vector operands. It maps the class to LLVM’sqconstraint and adds regression coverage for inline assembly using both custom#[repr(simd)]types and lane extraction.The lane extraction tests cover byte lanes from a 16-byte vector and 32-bit lanes from a four-word vector. The change also marks QR registers as clobbered by
clobber_abi("C")for ESP32-S3.This Rust change depends on the corresponding QR register support in [Espressif LLVM](https://github.com/espressif/llvm-project).
Testing
./x.py test tests/assembly-llvm/asm/xtensa-qreg.rs --stage 1ABI question
The implementation treats QR registers as caller-clobbered on ESP32-S3. The documentation I found identifies QR as general-purpose registers but does not explicitly state their C ABI preservation rule; please confirm this assumption.