Repository navigation
Only warn about simulated residuals when the Q-Q plot is requested - #1004
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the narrowly scoped warning-behavior change.
No open issues 🎉
What changed in this PR
This pull request updates check_model() so simulated-residual warnings appear only when the Q-Q plot is requested, avoiding misleading messages for checks such as homogeneity alone.
Changes:
- Restrict residual-simulation warnings to
checkvalues containing"qq"or"all". - Add regression coverage for homogeneity-only checks on binomial GLMs.
- Document the fix and increment the development package version.
| File | Description |
|---|---|
tests/testthat/test-check_model.R |
Verifies that homogeneity-only checks remain silent. |
R/check_model.R |
Restricts the simulated-residual alert to Q-Q plot requests. |
NEWS.md |
Documents the corrected alert behavior. |
DESCRIPTION |
Increments the development package version. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_model()printed "Cannot simulate residuals for models of classglm" whenevercheckleft out the Q-Q plot, for examplecheck_model(m, check = "homogeneity")for a binomial glm. Residuals are only simulated for the Q-Q plot, so the message now shows only when that plot was requested and the simulation failed.Part of #1003. This PR fixes the message only. It does not change the subtitle of the homogeneity panel, the other point in that issue.