Skip to content

Wire-up upgrade_sock_connect_accept_max_retries - #1012

Open
ethanhann wants to merge 3 commits into
cloudflare:mainfrom
ethanhann:bug/upgrade_sock_connect_accept_max_retries_unused
Open

ethanhann wants to merge 3 commits into
cloudflare:mainfrom
ethanhann:bug/upgrade_sock_connect_accept_max_retries_unused

Conversation

@ethanhann

Copy link
Copy Markdown
Contributor

upgrade_sock_connect_accept_max_retries (in pingora_core::server::configuration::ServerConf) was previously unused.

Related issue: #328

The original feature was added in this commit de4cc62, but it did not actually pass the retry setting through to the send_fds_to and get_fds_from function calls. The final argument is None instead of the retry setting which is fixed by this PR.

@drcaramelsyrup drcaramelsyrup added the bug Something isn't working label Sep 25, 2026
drcaramelsyrup pushed a commit that referenced this pull request Nov 9, 2026
…iguration options

---
Wire-up upgrade_sock_connect_accept_max_retries to actually control retry count during a graceful upgrade

Includes-commit: 4d22109
Includes-commit: 6621929
Replicated-from: #1012
@drcaramelsyrup drcaramelsyrup added the Accepted This change is accepted by us and merged to our internal repo label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted This change is accepted by us and merged to our internal repo bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants