Repository navigation
Fix POSIX MWD week-of-month and last-weekday normalization - #761
Merged
Merged
Conversation
Fixes three off-by-one/boundary errors in MwdForTime: - Subtract 1 before dividing day_of_month by 7 so days 7, 14, 21, and 28 stay in their current week block instead of jumping to the next week. - Check days_in_month > 28 rather than day_of_month > 28 when populating extra_days so week-5 (last-weekday) POSIX rules are not prematurely clamped to week 4 on days 1..=28. - Use day_29 <= last_day in normalize_mwd so 29-day leap-year Februaries (where day_29 == last_day) properly normalize week 5 to week 4 for the other six weekdays. Fixes boa-dev#759.
Manishearth
enabled auto-merge (squash)
November 1, 2026 10:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three off-by-one/boundary errors in MwdForTime:
Fixes #759.
Agent-driven