Skip to content

Shapes window: read offset from pipe shape_list - #24

Merged
DavidSagan merged 1 commit into
mainfrom
shapes-offset-from-pipe
Nov 8, 2026
Merged

DavidSagan merged 1 commit into
mainfrom
shapes-offset-from-pipe

Conversation

@DavidSagan

Copy link
Copy Markdown
Member

The Shapes window now reads each shape's offset from pipe shape_list. Tao with bmad-sim/bmad-ecosystem#2259 outputs it as a 10th field.

  • Reading: fetch_shapes runs pipe shape_list <who> directly and parses each line with the new parse_shape_list. With 10 fields, the offset is the 10th field.
  • Older Tao: with 9 fields, the offsets still come from show plot -<who>, as before.
  • Why not pytao: the GUI parses the raw lines because the released pytao's shape_list drops the extra field. Parse shape offset from shape_list (Tao bmad-ecosystem#2259) pytao#219 adds it.
  • Writing: unchanged. It uses set <who> ele_shape(i) = ..., which keeps every field on all Tao versions.

Testing

  • New test_parse_shape_list_with_and_without_offset covers 9- and 10-field lines.
  • Full suite: 63 passed, 1 skipped, both locally and in the conda-forge CI environment. Both use a Tao without #2259, so they run the show plot fallback; the existing Shapes window test checks the offset survives edits and moves.
  • By hand, against a libtao built with #2259 on tao_examples/cesr: parse_shape_list reports that the offset is present, and fetch_shapes returns offset 0.25 after set floor_plan ele_shape(2)%offset = 0.25.

🤖 Generated with Claude Code

Falls back to parsing show plot for Tao without the 10th field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DavidSagan
DavidSagan merged commit 594509c into main Nov 8, 2026
2 checks passed
@DavidSagan
DavidSagan deleted the shapes-offset-from-pipe branch November 8, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant