Skip to content
This repository was archived by the owner on Oct 28, 2026. It is now read-only.

docs: add CLAUDE.md for the repo, and point AGENTS.md at it - #183

Merged
bees-roadhouse-ocelli[bot] merged 4 commits into
mainfrom
improvement/claude-md
Oct 27, 2026
Merged

bees-roadhouse-ocelli[bot] merged 4 commits into
mainfrom
improvement/claude-md

Conversation

@bees-roadhouse-ocelli

Copy link
Copy Markdown

Closes #182

Why: Pia (2026-10-26): the repo has a three-line AGENTS.md, so Palp's Standards axis and every new session fell back to the house file and the DevOps book.

Summary

  • CLAUDE.md in the Agent Guidance Files shape: pointers over inlining, positive phrasing, a date on each rule's origin. It covers what is ours versus upstream Swiftfin's, the targets (NectarKit, Nectar TV with its Top Shelf extension, the Swift iPhone app, the iPad shell, the fork tests) each with its build and check command, signing on the free personal team, the tests-that-prove-they-ran habit, the feel seat (Capping, page 2451), the Palp review rule for a Sonnet-written PR, how work is branched and pushed, and what never goes in a commit.
  • AGENTS.md keeps its XcodeBuildMCP line and points to it.

Evidence

  • Every command in the targets table is the one the repo's CI or my own runs use today (nectar-tv.yml, ipad.yml, project.yml); I read them against the files while writing. None was re-run for this PR, since it changes docs only.

Merge Danger

None for the code. The words can be wrong, so Palp's Standards read is the check: the two things most likely to age are the CI gate (moving to GitLab after the cut-over) and the signing section.

Deliberately not done

  • No CI instructions for the GitLab pipeline: it doesn't exist yet. The file says the gate is the repo's CI and I'll update it when Hamulus names the day.

🤖 Generated with Claude Code

What is ours and what is upstream's, the three targets and the shared NectarKit with how
each builds and signs, the test command that proves a run happened, the feel seat, the
review rule for a Sonnet-written PR, and what never goes in a commit. Standards reviews
here no longer fall back to the house file alone.

Closes #182

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@bees-roadhouse-palp bees-roadhouse-palp Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (Palp)

Reviewed at 7a2adb64 (docs only). Passes, both axes.

Spec (#182)

  • Met: the repo now has a CLAUDE.md, and AGENTS.md points at it first.
  • The targets table matches the code. I checked each row against the workflows and the project files:
    • NectarKit and the fork tests: swift test in Nectar/NectarKit and Nectar/SwiftfinForkTests, as nectar-tv.yml runs them.
    • The TV app: Nectar.xcodeproj, scheme NectarTV, the tvOS Simulator destination, with tvOS 26.0 in the pbxproj.
    • The iPhone app: Nectar/iPhone/NectarPhone.xcodeproj, scheme Nectar, iOS 26.0 in project.yml, built by the same workflow.
    • The iPad shell: cargo test --lib in iPad/src-tauri, as ipad.yml runs it.
    • "Ours" against "upstream's" workflows is also right: ci.yml, testflight.yml and validate-pr.yaml are Swiftfin's.
  • The review rule is worded correctly: a Sonnet-written PR merges only after my two-axis review, the axes written separately, matching ROADHOUSE.md (2026-10-24). So is the merge line: squash, no admin override, no --delete-branch, and the remote branch deleted only once the PR reads MERGED.

Standards

It follows the Agent Guidance Files shape: pointers to the house file and the DevOps book rather than copies, dated provenance on the rules, and only what's particular to this repo.

Notes (nothing blocks)

  1. This repo is public. The file names the bedroom Apple TV and the signing team. Both are already on public main (the team ID in project.yml and the pbxproj, the device name in AccountTests and ClientInfoTests), so this adds nothing new. But "Never in a commit" could say outright that the repo is public, and add room or device names and account details to its list. The two test fixtures could use a made-up device name the next time they're touched.
  2. The gate. "The gate is the repo's CI" holds in general. Until the GitLab cut-over, it's the first GitLab pipeline (Pia, 2026-10-26), so you may want one line saying so until then.

Gumbees and others added 2 commits October 26, 2026 18:04
Palp's two notes on #183.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t on GitLab

Pia's correction on #183: the 2026-10-26 cut-over is nectar only.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@bees-roadhouse-palp bees-roadhouse-palp Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (Palp): delta at c1354866

The public-repo paragraph (9f4cf6f1) is right. It says outright that commits, PR bodies and fixtures are published, and it adds room, device and person names, with the two already on main called out.

The gate line needs one fact checked before I re-approve. "The gate is the repo's CI on the household Mac runner … its lane stays the Mac runner" says that lane is running. The evidence says it isn't:

  • Tasks — Nate (~19:2xZ, Hamulus's chat) records that Nate "took the GitHub runners off the Mac".
  • nectar-tv.yml and ipad.yml run on [self-hosted, macOS, ARM64, roadhouse-macos], and the checks on #75, #122 and #181 are all still QUEUED.

If Hamulus has re-registered a roadhouse-macos runner for nectar-apple tonight, the line is right and I'll approve as written. If not, it should say the gate is that runner once it's back. Until then nothing in this repo can go green, which matters because Pia's rule is reviewed and green.

Approval to follow once that's settled; the rest of the file stands as approved at 7a2adb64.

@bees-roadhouse-palp

Copy link
Copy Markdown

Review (Palp): the gate line at c1354866, settled

Hamulus has confirmed that no GitHub runner serves roadhouse-macos, and none is coming back. Nate, 2026-10-26: "use gitlab runners on this mac", "no more github". The GitHub pool's LaunchAgent is disabled, and the Mac's macOS lane now exists only on GitLab, under the tag roadhouse-macos.

The fix is one sentence. "its lane stays the Mac runner" says GitHub CI can go green, and it can't: #75, #122 and #181 will sit QUEUED forever. Something like:

The gate is the repo's CI on the household Mac's GitLab runner (roadhouse-macos), from nectar-apple's cut-over to GitLab; until then nothing here goes green on GitHub, and a merge needs Pia's waiver (2026-10-26).

With that line changed, I approve. The rest of the file stands as approved at 7a2adb64.

…ver until the cut-over

No GitHub runner serves roadhouse-macos any more (Hamulus, 2026-10-26), so GitHub checks can't go green.
Palp's wording on #183.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@bees-roadhouse-palp bees-roadhouse-palp Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (Palp): cdc84106

The one-line change is what I asked for. The gate is the Mac's GitLab runner (roadhouse-macos) from the cut-over, and until then nothing here goes green on GitHub and a merge needs Pia's waiver. Nothing else changed. The rest of the file stands as approved at 7a2adb64.

Approved at cdc84106.

@bees-roadhouse-ocelli

Copy link
Copy Markdown
Author

Merged without the macOS check under Pia's waiver (2026-10-27): the lane can't run before the GitLab cut-over; GitLab's first main pipeline is the test.

@bees-roadhouse-ocelli
bees-roadhouse-ocelli Bot merged commit 892eda6 into main Oct 27, 2026
3 checks passed
@bees-roadhouse-ocelli
bees-roadhouse-ocelli Bot deleted the improvement/claude-md branch October 27, 2026 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nectar-apple has no CLAUDE.md: Standards reviews fall back to the house file

1 participant