Skip to content

Fix glob vulnerability - #2561

Open
nikolawork wants to merge 1 commit into
beautifier:mainfrom
nikolawork:update-to-glob-14
Open

nikolawork wants to merge 1 commit into
beautifier:mainfrom
nikolawork:update-to-glob-14

Conversation

@nikolawork

@nikolawork nikolawork commented Nov 2, 2026 •

Copy link
Copy Markdown

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue: There is a security fix for glob that is only available on version 14: GHSA-3g3m-2fjr-6pw4

Closes #2562 and #2570.

Related to #2569.

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

A fix for GHSA-3g3m-2fjr-6pw4 is only available for version 14 of glob
@felixranesberger

Copy link
Copy Markdown

Bump

@noremacskich

Copy link
Copy Markdown

Bump

@felixranesberger

Copy link
Copy Markdown

Sorry for the direct ping, but this is a major blocker for us right now @bitwiseman

@nikolawork nikolawork mentioned this pull request Nov 17, 2026
2 of 6 tasks
@seebaermichi

Copy link
Copy Markdown

I tested this PR and #2569 locally (macOS, Node 22.22.0 and 24.21.0), separately and merged together, in case that saves review time.

What I ran: the JavaScript half of make ci: npm ci, test/generate-tests.js, tools/build.sh js, mocha --recursive js/test, node-src-index-tests.js, npm pack plus installing the tarball, node-beautify-tests.js, amd-beautify-tests.js and js/test/shell-test.sh. The shell tests cover the CLI, including the .editorconfig cases, which is the only code that uses glob and editorconfig. I skipped the Python half because neither PR touches it.

Results:

Branch All JS steps git status after build npm audit --omit=dev
main pass clean glob, minimatch, editorconfig, brace-expansion
#2561 pass clean minimatch, editorconfig, brace-expansion (via editorconfig 3 → minimatch 10)
#2569 pass clean glob, minimatch, brace-expansion (via glob 13 → minimatch 10)
#2561 + #2569 pass clean none

So each PR alone fixes only half of the advisories. Together they clear every production advisory (GHSA-3g3m-2fjr-6pw4, GHSA-g3hv-75wg-m249 and the brace-expansion ones that come in through minimatch 10).

Notes:

  • The two PRs conflict with each other, but only on the dependencies lines in package.json and in package-lock.json. After merging one, running npm install --package-lock-only on the other resolves it.
  • Engines: editorconfig 4 needs Node >= 22 (and commander 15 >= 22.12), but this changes nothing in practice. nopt 10.0.1, already on main, requires ^22.22.2 || ^24.15.0 || >=26.0.0, and CI already tests only 22/24/26. package.json still says "node": ">=14", though, so it may be worth updating that at the same time.
  • A small suggestion: "glob": "^14.0.2" instead of "^14.0.0", so the range itself excludes the vulnerable 14.0.0/14.0.1 (the lockfile already resolves 14.0.3).

A release with both would let downstream projects drop their overrides for these advisories. Thanks for maintaining js-beautify!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glob vulnerability: GHSA-3g3m-2fjr-6pw4

4 participants