Repository navigation
fix(athena): apply max_results in list_query_executions when no workgroup is given - #3579
Open
abhishekacharya200 wants to merge 1 commit into
Open
abhishekacharya200 wants to merge 1 commit into
abhishekacharya200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
wr.athena.list_query_executions, theif max_results is not Noneblock was nested insideif workgroup:, so when no workgroup was passedmax_resultsnever reached theMaxResultsparameter. The first request returned a full page (up to 50 ids) regardless ofmax_results, and the result wasn't capped.MaxResultsassignment out of the workgroup block so it applies in both cases.tests/unit/test_athena_mocked.py(workgroup None/set, max_results 3/60). The two no-workgroup cases fail without the change and pass with it.Relates
max_resultstoathena.list_query_executions#2665 (addedmax_results)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.