Repository navigation
fix(cleanrooms): read the lowercase error key when wait_query fails - #3577
Open
abhishekacharya200 wants to merge 1 commit into
Open
abhishekacharya200 wants to merge 1 commit into
abhishekacharya200 wants to merge 1 commit into
Conversation
GetProtectedQuery returns the failure details under protectedQuery.error.message, but wait_query looked up the capitalised Error key, so QueryFailed was always raised with None. Read error.message instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
cleanrooms.wait_queryraisedQueryFailedwithresponse["protectedQuery"].get("Error"). The Clean Rooms GetProtectedQuery response uses a lowercaseerrorkey (a structure withmessageandcode), so the exception message was alwaysNone. It now readserror.message.tests/unit/test_cleanrooms_mocked.py) that fails before the change and passes after.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.