Repository navigation
fix(timestream): include the batch load task ErrorMessage in TimestreamLoadError - #3574
Open
abhishekacharya200 wants to merge 2 commits into
Open
abhishekacharya200 wants to merge 2 commits into
abhishekacharya200 wants to merge 2 commits into
Conversation
…ait_batch_load_task Signed-off-by: abhishekacharya200 <abhishekacharya200@users.noreply.github.com>
Karishmashaik9
left a comment
There was a problem hiding this comment.
Could we also add a test for a failed batch load response where ErrorMessage is missing? Since this is an optional response field, it would be good to verify that the function still raises TimestreamLoadError without introducing an unexpected exception.
Contributor
Author
|
Good point, thanks @Karishmashaik9. Added |
Karishmashaik9
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
wait_batch_load_taskraisedTimestreamLoadError(response.get("ErrorMessage")), butErrorMessageis a member ofBatchLoadTaskDescriptionin theDescribeBatchLoadTaskresponse, not of the top-level response. The lookup always returnedNone, so a failed (or progress-stopped / pending-resume) batch load task raisedTimestreamLoadError(None)and the service's failure reason was lost.response["BatchLoadTaskDescription"]instead (the key is optional in the model, so.getis kept).tests/unit/test_timestream_mocked.pythat fails before and passes after. No AWS account needed.Relates
https://docs.aws.amazon.com/timestream/latest/developerguide/API_DescribeBatchLoadTask.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.