Repository navigation
Fix dissemination queue comparison operator - #86
Merged
Merged
Conversation
Zaltad
force-pushed
the
wrong-comparison
branch
from
October 29, 2026 20:53
ae3c599 to
022127e
Compare
There was a problem hiding this comment.
🟡 Changes recommended
A stalled quorum wait prevents queued cleanup futures from being polled, leaving earlier batches’ 500 ms deadlines unenforced and their transmission handles alive indefinitely.
1 open issue
What changed in this PR
Corrects the mempool’s dissemination queue check so batches can retain transmission handles briefly after reaching quorum, giving slower peers time to receive them.
Changes:
- Enqueues pending dissemination work while the queue is below its limit, rather than only when it is already full.
| File | Description |
|---|---|
mempool/src/quorum_waiter.rs |
Reverses the queue-capacity comparison to allow pending dissemination work. |
Review effort: Balanced
| // immediately dropping the handles. | ||
| // TODO: We should allocate resource per peer (not in total). | ||
| if pending_counter >= DISSEMINATION_QUEUE_MAX { | ||
| if pending_counter < DISSEMINATION_QUEUE_MAX { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I think comparison operator is inverted here and pending never has elements pushed to it (given that pending_counter = 0; is initialized).