Repository navigation
Conversation
kayx23
force-pushed
the
docs/fix-admin-api-generation
branch
from
November 16, 2026 04:53
956e3ce to
1f78959
Compare
kayx23
force-pushed
the
docs/fix-admin-api-generation
branch
from
November 16, 2026 05:02
1f78959 to
e916a54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecretPatchschemas and nullable merge-patch fieldsUpstream.typeopen for user-defined balancer modulesadmin-api.jsonWhy
The modular Admin API source generated a valid OpenAPI 3.1 document, but it dropped schema detail that the reference renderer and downstream quality checks rely on. In particular, the generated
SecretPatchbecame an unstructured object, several enums lost their descriptions, and unconstrained arrays omitteditemsentirely.Upstream.typeis intentionally not converted to an enum: APISIX has supported user-defined balancers since #4605. The description lists the built-in implementations without closing the field to extensions.Validation
make bundle-admin-api-specpython -m unittest discover -s t/openapi -v(20 tests)python utils/validate-admin-api.pypython utils/validate-control-api.pygit diff --check