Skip to content

(components) Transform.init applies its scale - #54

Merged
nevyn merged 1 commit into
mainfrom
transform-init-scale
Sep 17, 2026
Merged

nevyn merged 1 commit into
mainfrom
transform-init-scale

Conversation

@nevyn

@nevyn nevyn commented Sep 17, 2026

Copy link
Copy Markdown
Member

Transform.init(translation:rotation:scale:) accepted scale: and dropped it, so a caller got an unscaled transform with no sign of it. The float4x4.scale setter that the TODO was waiting on is correct; the init now uses it.

TransformTests round-trips translation, a skew-axis rotation and a non-uniform scale through the init and the getters, and pins the T·R·S order. It failed on the two scale expectations before the fix.

No caller in KojaApp, KojaNet, KojaServ or the demo apps passes scale:, so nothing changes appearance. Transform is still one matrix on the wire: no protocol bump.

🤖 Generated with Claude Code

The init accepted `scale:` and dropped it, so a caller got an unscaled
transform without any sign of it. The float4x4 scale setter it was waiting on
is correct; a round-trip test through the init and the getters pins that. No
caller passes `scale:` today, and the wire format is still one matrix.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T13:44:42.933877Z aa23c8b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nevyn
nevyn merged commit c27d008 into main Sep 17, 2026
6 checks passed
@nevyn
nevyn deleted the transform-init-scale branch September 17, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant