Repository navigation
(components) Transform.init applies its scale - #54
Merged
Merged
Conversation
The init accepted `scale:` and dropped it, so a caller got an unscaled transform without any sign of it. The float4x4 scale setter it was waiting on is correct; a round-trip test through the init and the getters pins that. No caller passes `scale:` today, and the wire format is still one matrix. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transform.init(translation:rotation:scale:)acceptedscale:and dropped it, so a caller got an unscaled transform with no sign of it. Thefloat4x4.scalesetter that the TODO was waiting on is correct; the init now uses it.TransformTestsround-trips translation, a skew-axis rotation and a non-uniform scale through the init and the getters, and pins the T·R·S order. It failed on the two scale expectations before the fix.No caller in KojaApp, KojaNet, KojaServ or the demo apps passes
scale:, so nothing changes appearance. Transform is still one matrix on the wire: no protocol bump.🤖 Generated with Claude Code