Repository navigation
solve undefined value property issue - #1465
Closed
dharamdan01 wants to merge 1 commit into
Closed
dharamdan01 wants to merge 1 commit into
dharamdan01 wants to merge 1 commit into
Conversation
Member
|
I don't know what this is, but I'm going to assume you let your 'agent' do some dumb stuff and are dumping it on us without further inspection. I don't have time for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1285
This PR fixes the missing
valueproperty in Acorn'sTokenTypeScript definition.Although
tokenizer().getToken()returns tokens containing avalueat runtime, TypeScript previously rejected valid usage withProperty 'value' does not exist on type 'Token'.🛠️ How Was This Implemented?
Tokentype.valueproperty to TypeScript consumers.token.getToken().valueto type-check withoutas anyor manual type casting.Visuals
🧪 Testing Instructions
acorn.tokenizer().getToken()and accesstoken.value.valueproperty.