[yileicn]

The webhook queue and ConversationRelay processor, and the transcribe callback, loaded conversation states without any identity, and the record callback authenticated after loading states, overwriting the identity restored from them. Authenticate first in all three so the session hook's identity is the fallback and state loading can still replace it with the caller's own.

[qodo-code-review]

Code Review by Qodo

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.

[qodo-code-review]

PR Summary by Qodo

Authenticate Twilio callbacks and caller turns before loading states

🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Authenticate webhook, ConversationRelay, transcription, and recording flows before conversation
 states load.
• Preserve the authenticated identity as a fallback while allowing stored state to restore the
 caller’s identity.

Diagram

graph TD
  Q["Caller processor"] --> S["Session hook"] --> C["Conversation states"] --> I["Caller identity"]
  T["Transcribe callback"] --> S
  R["Recording callback"] --> H["Status hook"] --> C

Loading

High-Level Assessment

Using the existing Twilio hooks before SetConversationId is the smallest consistent fix across these flows. A separate authentication mechanism would duplicate the hooks without improving identity precedence.

Files changed (3) +18 / -1

Bug fix (3) +18 / -1

TwilioRecordController.csAuthenticate recording callbacks before loading states +3/-1

Authenticate recording callbacks before loading states

• Moves the call-status authentication hook ahead of SetConversationId and SaveStates. A caller identity restored during state loading is no longer overwritten afterward.

src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioRecordController.cs

TwilioTranscribeController.csAuthenticate transcription callbacks before loading states +4/-0

Authenticate transcription callbacks before loading states

• Invokes the synchronous session authentication hook before SetConversationId for completed transcriptions with text. The hook supplies a fallback identity that state loading may replace.

src/Plugins/BotSharp.Plugin.Twilio/Controllers/TwilioTranscribeController.cs

TwilioConversationProcessor.csAuthenticate shared caller-message processing +11/-0

Authenticate shared caller-message processing

• Builds an authentication request from the caller message and invokes the session hook before conversation initialization. This covers both webhook-queue and ConversationRelay caller turns.

src/Plugins/BotSharp.Plugin.Twilio/Services/TwilioConversationProcessor.cs