Skip to content

feat: #193 checkup of curve-data-table - #293

Merged
anneke merged 3 commits into
mainfrom
feat/193-checkup-of-tables
Nov 5, 2026
Merged

anneke merged 3 commits into
mainfrom
feat/193-checkup-of-tables

Conversation

@anneke

@anneke anneke commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • dark mode fix, layout didn't quite work
  • accessibility check
  • added react equivalent for parity

Related issue

Closes #193

Type of change

  • Fix
  • New feature / variant
  • Breaking change
  • Docs / repo tooling (no package code changed)
  • Chore / refactor

Checklist

  • pnpm build, pnpm lint, and pnpm format pass
  • Storybook story added/updated to cover the change (variants, sizes, states)
  • Visual snapshots updated (pnpm test:visual:update after pnpm build-storybook) if appearance changed
  • Changeset added (pnpm changeset) — required for any change to @surfnet/curve-react or @surfnet/curve-angular; N/A for docs/CI-only changes
  • React and Angular kept in parity, if applicable (contract updated in @surfnet/curve-contracts)

Screenshots

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

♿ Accessibility audit — WCAG 2.2 AA

✅ No violations across 396 stories / 15048 theme·mode combinations in @surfnet/curve-angular, @surfnet/curve-react.

Automated axe covers ~30–50% of WCAG 2.2 AA. Keyboard, screen-reader and reflow checks still need a manual pass. Full per-story JSON is in the run’s a11y-reports artifact.

@anneke
anneke force-pushed the feat/193-checkup-of-tables branch from 5979a4b to 1f142a1 Compare November 5, 2026 11:57
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
Signed-off-by: Anneke Sinnema <mail@annekesinnema.nl>
@anneke
anneke force-pushed the feat/193-checkup-of-tables branch from 1f142a1 to 2760bee Compare November 5, 2026 11:58
@anneke
anneke merged commit 2f06a83 into main Nov 5, 2026
1 check passed
@anneke
anneke deleted the feat/193-checkup-of-tables branch November 5, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Todo: Check tables/curve data table

1 participant