Skip to content

Add asset specification support to FileResponse - #3836

Open
luhn wants to merge 7 commits into
Pylons:mainfrom
luhn:fileresponse-asset
Open

luhn wants to merge 7 commits into
Pylons:mainfrom
luhn:fileresponse-asset

Conversation

@luhn

@luhn luhn commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Add support for asset specifications (e.g. mypackage:static/foo.png) to pyramid.response.FileResponse.

luhn added 6 commits November 10, 2026 23:16
Considerations:  I'm using `get_current_request` so I can use
`request.resolve_asset` when a request isn't explicitly specified.
This implicit request is then used for `wsgi.file_wrapper`, which is a
small behavior change.  I would think this would be fine, and possibly
even preferred, but I'm not sure.
@luhn
luhn requested a review from mmerickel November 11, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant