Repository navigation
Build version metadata before proofauto - #873
Merged
andrew-appel merged 1 commit intoNov 9, 2026
Merged
andrew-appel merged 1 commit into
andrew-appel merged 1 commit into
Conversation
Add the missing dependency on generated veric/version.vo so fresh parallel floyd builds can load version metadata reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
floyd/proofauto.vrequiresVST.veric.version, whichutil/make_versiongenerates. On a fresh tree coqdep runs beforeveric/version.vexists, so.dependhas no edge fromfloyd/proofauto.votoveric/version.vo. A parallel build can then compile proofauto before the version metadata. This adds the dependency to the Makefile.The race hit me repeatedly when building VST in Nix sandboxes, where every build starts from a fresh tree.
Tested with a clean
make -j6 vston stock Rocq 9.1.1 with CompCert 3.18.