Skip to content

sui-rpc: vendor the MovePackageService package APIs - #341

Open
nickvikeras wants to merge 2 commits into
nickv/refusal-reasonsfrom
nickv/package-at-checkpoint-errors
Open

nickvikeras wants to merge 2 commits into
nickv/refusal-reasonsfrom
nickv/package-at-checkpoint-errors

Conversation

@nickvikeras

@nickvikeras nickvikeras commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Vendor the package APIs from MystenLabs/sui-apis #51, #41, #44, #45 and #50 (84f0533, nickv/list-system-packages) and regenerate the bindings. GraphQL's package queries (packageVersions*, Query.packages, Epoch.systemPackages) still read Postgres; these RPCs let them move to MovePackageService.

  • GetPackageRequest.at_checkpoint outside the indexed range fails with OUT_OF_RANGE and reason ABOVE_LATEST_AVAILABLE or BELOW_EARLIEST_AVAILABLE (sui-apis#51).
  • PackageVersion.checkpoint, and ListPackageVersionsRequest.at_checkpoint to list only versions published at or before a checkpoint (sui-apis#41).
  • Cursor paging (options) and start_version/end_version bounds for ListPackageVersions, with PackageVersion.cursor (sui-apis#44).
  • ListPackageVersions with package_id unset lists every package's versions in publish order, bounded below by start_checkpoint; PackageVersion.original_id (sui-apis#45).
  • MovePackageService.ListSystemPackages, with new constructors for its request and response (sui-apis#50).

The first commit only vendors and regenerates; the second updates the hand-written constructors. Supersedes #328, #331, #332 and #340.

Stacked on #346.

@nickvikeras
nickvikeras force-pushed the nickv/package-at-checkpoint-errors branch from 13b574a to 078ab77 Compare November 5, 2026 15:36
@nickvikeras nickvikeras changed the title sui-rpc: GetPackage at_checkpoint outside the indexed range fails with OUT_OF_RANGE and an ErrorReason sui-rpc: vendor the MovePackageService package APIs Nov 5, 2026
@nickvikeras
nickvikeras marked this pull request as ready for review November 5, 2026 15:54
@nickvikeras
nickvikeras requested a review from bmwill as a code owner November 5, 2026 15:54
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 6, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 7, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
@nickvikeras
nickvikeras force-pushed the nickv/package-at-checkpoint-errors branch from 7c67fe3 to e261a32 Compare November 13, 2026 06:33
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 13, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
@nickvikeras
nickvikeras force-pushed the nickv/package-at-checkpoint-errors branch from e261a32 to 0444494 Compare November 13, 2026 17:44
@nickvikeras
nickvikeras changed the base branch from master to nickv/refusal-reasons November 13, 2026 17:45
@nickvikeras
nickvikeras force-pushed the nickv/refusal-reasons branch from 91a772a to c20455f Compare November 13, 2026 18:00
@nickvikeras
nickvikeras force-pushed the nickv/package-at-checkpoint-errors branch from 0444494 to 1c2afe3 Compare November 13, 2026 18:00
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
nickvikeras added a commit that referenced this pull request Nov 14, 2026
# Conflicts:
#	crates/sui-rpc/src/proto/generated/sui.rpc.v2.fds.bin
@nickvikeras
nickvikeras force-pushed the nickv/package-at-checkpoint-errors branch from 1c2afe3 to 68c7391 Compare November 14, 2026 21:50
Vendor the protos from MystenLabs/sui-apis nickv/list-system-packages
(a33005a: sui-apis #51, #41, #44, #45 and #50) and regenerate the bindings.

- GetPackageRequest.at_checkpoint outside the indexed range fails with
  OUT_OF_RANGE and reason ABOVE_LATEST_AVAILABLE or BELOW_EARLIEST_AVAILABLE.
- PackageVersion.checkpoint, and ListPackageVersionsRequest.at_checkpoint to
  list only the versions published at or before a checkpoint.
- Cursor paging (options) and start_version/end_version bounds for
  ListPackageVersions, with PackageVersion.cursor.
- ListPackageVersions with package_id unset lists every package's versions in
  publish order, bounded by start_checkpoint; PackageVersion.original_id.
- MovePackageService.ListSystemPackages.
Initialize the new ListPackageVersionsRequest and PackageVersion fields in their constructors, and add `new` constructors for ListSystemPackagesRequest and ListSystemPackagesResponse.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant