Repository navigation
Conversation
- Manager: track whether the daemon was actually reachable and render "— (daemon not running)" plus a DaemonDownCard when it was not, instead of presenting default HealthIssue values as the framework's own report. - Daemon: log lock contention separately from IO/SELinux failures, and use a neutral message when another daemon already holds the lock. - Launcher: keep the parent shell, capture stderr to /data/adb/lspd/log/bootstrap.log, append "vectord exited with code N", and propagate the exit status instead of discarding all launch evidence. No sepolicy, native, API, or ABI changes; no automatic restart or forced activation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes Vector's failure state honest and diagnosable, without changing injection behaviour.
FrameworkStatus.daemonReachable. When no daemon binder answers, the status page shows— (daemon not running)for the SELinux / system framework / dex2oat rows — instead of rendering the defaultfalsevalues as "not loaded / not injected" — and adds aDaemonDownCardwith the two checks worth making. This matters on KernelSU/SukiSU LKM late-load boots, where post-fs-data is skipped and nothing starts.FileSystem.tryLock(), and uses a neutral log line when the lock is already held.zygisk/module/daemon): keeps the parent shell instead ofexec, captures stderr to/data/adb/lspd/log/bootstrap.log, appendsvectord exited with code N, and exits with the child's status. Previously>/dev/null 2>&1discarded every trace of a daemon that exits beforemain.No sepolicy, native, API or ABI changes; no automatic restart, soft reboot, or forced activation.
Why
On a Xiaomi Pad 9 Pro Max (HyperOS 4 / Android 17) with SukiSU KernelSU LKM late-load:
KernelSU: post-fs-data skipped (late load)leaves the module's policy unapplied and zygote/system_server uninjected;vectordis still launched from the services stage but exits beforemain(3 ms–3 s, no stderr), so there is no daemon at all;This PR is the diagnostics half. It does not attempt to fix late-load or restart system_server/zygote.
Testing
./gradlew --no-daemon :daemon:assembleDebug :zygisk:assembleDebug— BUILD SUCCESSFUL../gradlew --no-daemon :manager:assembleDebug zipAll— BUILD SUCCESSFUL (490 tasks).git diff --check,sh -n zygisk/module/daemon— clean.ktfmtCheck— only pre-existing baseline failures.ksud post-fs-data+ zygote restart,cli status= Framework 2.2 / VersionCode 3118 / API 102 and the manager status source reportssystemServerRequested=true. The manager UI itself was not re-tested with this debug-signed build (device has release-signed manager 3080).app_processexiting 7 →bootstrap.logcontainsvectord exited with code 7, wrapper exits 7; unwritable log dir falls back to/dev/nullwithout breaking launch.Notes