Repository navigation
Fix missing RecordTag superclass causing NoClassDefFoundError - #1080
Open
AhmadAddas wants to merge 2 commits into
Open
AhmadAddas wants to merge 2 commits into
AhmadAddas wants to merge 2 commits into
Conversation
Package AGP's generated record support with the framework so constructing an invoker no longer fails on the missing RecordTag superclass. Merge the finalized APK DEX set into one classes.dex, retain separate debug/release intermediate paths, and package it once as framework/vector.dex. Reject missing record support or output exceeding the single-DEX loader. Add direct debug/release packaging and missing-support regression tests. The regression suite passed in this fresh checkout.
eyeyeeyey83-hue
approved these changes
Nov 13, 2026
Author
|
My bad I thought it is merged when I closed it, feel free to close it from your end with approved commit changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Vector's invoker records can reference a missing
com.android.tools.r8.RecordTagsuperclass, causingNoClassDefFoundErrorwhen constructingBaseInvoker.RecordTagprovides Java record compatibility on older Android versions.Vector uses these records to choose between calling the original method and
executing a hook chain.
Fix
required global synthetics, including
RecordTag.framework/vector.dex, keepingVector's single-DEX runtime loader unchanged.
regression tests.
Validation
zipAllbuild.View the successful GitHub Actions run.
RecordTagor invokerChainresolution errors appeared in the capturedpost-boot logs.
Testing limitation
Android blocked direct method tracing because WhatsApp is not
debuggable/profileable. The original-method call's native execution and return
value were therefore not directly traced. This is a testing limitation,
not an observed failure.