Repository navigation
Conversation
ImranR98
commented
Nov 1, 2026
Owner
- Fall back to dart:io when Android memory DCL is restricted ("Obtainium tried to perform DCL via memory" after the latest update #3442)
- Fix signing certificate checks on Android 9 and 10 (Signing certificate check always reads None on Android 9 and 10 #3475)
- Prefer the ABI-specific APK when the saved choice is universal ("Attempt to filter APKs by CPU architecture if possible" toggle ignored #3473)
- Remove the defunct APKCombo source (Remove apkcombo #3468)
GrapheneOS's "Dynamic code loading via memory" setting blocks the anonymous executable memory used by cronet_http's FFI callback trampolines, so Obtainium crashed on launch for users who restrict it. Detect the effective DENY_EXECMEM flag from /proc/self/attr/grapheneos_flags (or the older selinux_flags attribute), which is what GrapheneOS's SELinuxFlags.isExecmemBlocked() reads. If neither attribute exists, fall back to an mmap(PROT_EXEC) probe. When memory DCL is blocked, skip Cronet and use the existing dart:io client; show a one-time dialog explaining that user-installed/disabled CAs and system proxy settings are unavailable in the fallback. Add a "Use Android certificate store" setting (default on) so users can opt out of Cronet even when DCL is allowed. It renders off and disabled while DCL is blocked. The app's native libraries remain uncompressed in the APK with extractNativeLibs=false; this is memory DCL, not storage DCL. Verified: analyze, format, all unit/widget tests; normal release build; phone E2E smoke, add/remove, add defaults, forms, search/source, settings/navigation and related suites. The Cronet-in-use assertion still passes on the stock emulator. No GrapheneOS device was available, so the restricted branch is covered by unit tests and code analysis only. The install/update E2E suites were not completed (emulator silent-install support and a network-interrupted download test).
Android 9 and 10 only collect archive certificates in PackageManager.getPackageArchiveInfo() when GET_SIGNATURES is set. Obtainium requested only GET_SIGNING_CERTIFICATES, so every allowed-hash check saw an empty hash set and blocked the install. Add PMFlag.getSignatures to the pinned android_package_manager fork and request both flags, keeping SigningInfo on API 30+ while making API 28/29 collect the certificates. Verified with flutter analyze, dart format, and the full unit suite. On an API 28 emulator the signing certificate check now reports matching non-empty hashes for the installed app and the good APK, and a different set for the bad-key APK; the install-flow assertions cannot complete there because silent install requires API 31+. The same hash check produced matching non-empty hashes on the API 37 emulator.
#3349 kept universal APKs as an alternative and placed them first in the filtered list. Apps whose preferred index points at that universal entry therefore preselect it, so the architecture filter appears to do nothing. When auto architecture filtering is enabled, resolve a saved universal preference to the first APK matching a supported ABI. A saved ABI-specific choice is left alone, and universal is still offered in the picker. Verified with flutter analyze, dart format, the full unit suite, and the API 37 emulator: adding WebSpace and refreshing with the filter enabled now preselects webspace-x86_64.apk instead of webspace-universal.apk.
Changelog links were resolved against the source origin, so a relative link like CHANGELOG.md opened github.com/CHANGELOG.md instead of the file at the release tag. Add a source-aware resolveChangeLogLink() hook: GitHub resolves against /blob/<tag>/ and GitLab against /-/blob/<tag>/, using the release URL tag when available and the latest version as fallback. GitHub now records the release URL from the release payload. Verified with flutter analyze, dart format, the full unit suite, and the API 37 emulator: tapping CHANGELOG.md in BasicSync's v3.27 changelog captured https://github.com/chenxiaolong/BasicSync/blob/v3.27/CHANGELOG.md.
APKCombo's domains are gone: apkcombo.com returns NXDOMAIN and is in the registrar's redemption period, while apkcombo.app and apkcombo.io are also NXDOMAIN. The source can no longer resolve a page or asset. Delete the source, its registry entry, and the APKCombo entries in the README and English fastlane description. Existing APKCombo apps will no longer resolve a source, which matches the site's state. Verified with flutter analyze, dart format, the full unit suite, and the API 37 emulator: APKCombo is absent from Supported sources.
#3471 now provides the changelog link resolution used by the UI, including soft line breaks. Remove the parallel AppSource/GitHub/GitLab resolver and its test so there is only one implementation.
#3460 changed four English certificate-prompt strings. Twenty-four locales still contained the old English text as placeholders. Replace only exact copies of the four old English values; translated values and all keys remain unchanged.
The stable channel moved from 3.47.8 to 3.47.9, a patch release whose changes are all in flutter_tools (Windows MAX_PATH handling, a native assets StateError in pub workspaces, and the extensible ContextMenuButtonKind in the framework). Neither Dart (3.13.7) nor the Android toolchain requirements changed: the SDK constants still ask for Gradle 9.3.1, AGP 9.1.0, Kotlin 2.4.0, compileSdk 36 and NDK 28.2.13676358, while the repo keeps its deliberate, working values ahead of the template (Gradle 9.4.1, AGP 9.2.1, Kotlin 2.4.10, compileSdk 37.0). flutter analyze --suggestions reports the Java/Gradle/AGP/KGP combination as compatible, so no Android files changed. Verified: flutter analyze clean, dart format clean, flutter test (485 passed), flutter build apk --flavor normal succeeded, and the E2E smoke suite passed on the API 37 emulator. The remaining E2E suites could not finish because the emulator segfaulted mid-run; the pre-existing KGP warnings are unchanged and come from android.builtInKotlin=false, which is still required by cronet_http.
Upgrade pub dependencies to their latest resolvable versions with `flutter pub upgrade --tighten --major-versions`. All bumps are minor or patch: flutter_local_notifications 22.3.2 -> 22.3.3, cronet_http 1.10.0 -> 1.10.1 (an AGP 9 namespace fix), material_ui 1.8.0 -> 1.9.0, file_picker 13.2.0 -> 13.3.0, archive 4.5.2 -> 4.6.0, crypto 3.0.7 -> 3.0.8, plus the matching transitive bumps (jni 1.1.1, posix 6.5.4, vector_math 2.4.4, the shared_preferences and file_picker platform packages). No git dependency SHA pins changed. Lift the fluttertoast hold: it was pinned to exactly 10.0.0 because 10.0.1+ applies KGP unconditionally and failed under AGP 9's built-in Kotlin. Built-in Kotlin is currently off (android.builtInKotlin=false, still required by cronet_http) and 10.0.2 builds cleanly on the standalone KGP setup, so the pin and its stale TODO are gone. If built-in Kotlin is re-enabled, re-check fluttertoast along with the other KGP-applying plugins. Carries the pending 1.7.4+2362 version bump at the maintainer's request. Verified: flutter analyze clean, dart format clean, flutter test (485 passed), and flutter build apk --flavor normal from a clean tree. E2E on the API 37 emulator: 15 of 18 suites passed. install_update_test failed with NO_VERSION on the background-isolate download of testapp-v2.apk, which cronet_http's changelog does not explain (1.10.1 only fixes an AGP 9 namespace clash). signing_cert_test and install_as_downloaded_test never ran because the emulator segfaulted (qemu SIGSEGV, recurring on this host) before reaching them, so those three remain unverified.
|
Pull request successfully merged and closed"my branch has been marged" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.