Repository navigation
fix(graphics): draw an empty ClearCodec V-bar cache entry instead of failing - #2433
Open
shellden-dev (shellden-dev) wants to merge 1 commit into
Open
shellden-dev (shellden-dev) wants to merge 1 commit into
shellden-dev (shellden-dev) wants to merge 1 commit into
Conversation
…failing A ClearCodec bands layer can refer to a V-bar cache entry that the decoder never stored. Windows servers do this, for example after a cache reset. The decoder returned an error for the whole update, so text-heavy regions from Windows hosts stayed unpainted. FreeRDP reads such an entry as an empty bar and keeps decoding. Now a full V-bar hit on an empty entry gives a column of zero pixels, and a short V-bar hit on an empty entry gives zero pixel rows, so the column is the band background. The yOn bound check still applies. Tested with new decoder tests in ironrdp-testsuite-core for both cache hit kinds and the yOn check; the first two fail without the change.
shellden-dev (shellden-dev)
temporarily deployed
to
llm-providers
November 14, 2026 08:25 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
kind/protocol
shellden-dev (shellden-dev)
force-pushed
the
shellden/clearcodec-vbar-cache-miss
branch
from
November 14, 2026 15:41
a7788a1 to
dae51b2
Compare
shellden-dev (shellden-dev)
deployed
to
llm-providers
November 14, 2026 15:41 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ClearCodec bands layer can refer to a V-bar cache entry that the decoder never stored. Windows servers do this, for example after a cache reset. The decoder returned an error for the whole update, so text-heavy regions from Windows hosts stayed unpainted.
FreeRDP reads such an entry as an empty bar and keeps decoding. Now a full V-bar hit on an empty entry gives a column of zero pixels, and a short V-bar hit on an empty entry gives zero pixel rows, so the column is the band background. The yOn bound check still applies.
Tested with new decoder tests in ironrdp-testsuite-core for both cache hit kinds and the yOn check; the first two fail without the change.